Typefaces #55
Merged
Typefaces #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arcticicestudio
commented
Dec 2, 2018
arcticicestudio
commented
Installed the - main stylistic and visualization sans-serif font Rubik (1) through the typeface-rubik (2) package. - sans-serif font Inter UI (3) for documentations, technical and factual content through the `i`nter-ui (4) package. - main monospace font Source Code Pro (5) for all code elements through the typeface-source-code-pro (6) package. References: (1) https://fonts.google.com/specimen/Rubik (2) https://www.npmjs.com/package/typeface-rubik (3) https://rsms.me/inter (4) https://www.npmjs.com/package/inter-ui (5) https://fonts.google.com/specimen/Source+Code+Pro (6) https://www.npmjs.com/package/typeface-source-code-pro GH-54
In order to use the fonts is must be added to Nord Docs theme. This commit implements the `typography` module that defines all used font families and the basic typography properties and values like the font size and units based on the used modular scale documented in GH-2. Associated epic: GH-2 Dependency of GH-53 GH-54
Codecov Report
@@ Coverage Diff @@
## develop #55 +/- ##
============================================
- Coverage 100% 44.44% -55.56%
============================================
Files 2 4 +2
Lines 4 9 +5
============================================
Hits 4 4
- Misses 0 5 +5
Continue to review full report at Codecov.
|
svengreb
approved these changes
Dec 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.